Steps:

I updated to the latest version using pip install -U git+https://github.com/Irrational-Encoding-Wizardry/vs-preview.git --user

Issue:

Upon trying to load vspreview with any vpy script, or even running vspreview --help or vspreview --version, I receive a crash with the following backtrace:

Traceback (most recent call last):
  File "C:\Users\jholm\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\jholm\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\jholm\AppData\Local\Programs\Python\Python310\Scripts\vspreview.exe\__main__.py", line 4, in <module>
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\__init__.py", line 1, in <module>
    from .init import main  # noqa: F401
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\init.py", line 18, in <module>
    from .main import MainSettings, MainWindow
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\main\__init__.py", line 3, in <module>
    from .window import *  # noqa: F401, F403
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\main\window.py", line 26, in <module>
    from ..toolbars import Toolbars
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\toolbars\__init__.py", line 12, in <module>
    from .main import MainToolbar
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\toolbars\main\__init__.py", line 1, in <module>
    from .toolbar import *  # noqa: F401, F403
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\toolbars\main\toolbar.py", line 13, in <module>
    from .dialog import FramePropsDialog
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\toolbars\main\dialog.py", line 57, in <module>
    } | dict([
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\toolbars\main\dialog.py", line 58, in <listcomp>
    _create_enum_props_lut(enum, name)
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\toolbars\main\dialog.py", line 25, in _create_enum_props_lut
    pretty_name: {
  File "C:\Users\jholm\AppData\Roaming\Python\Python310\site-packages\vspreview\toolbars\main\dialog.py", line 26, in <dictcomp>
    idx: enum.from_param(idx).pretty_string if enum.is_valid(idx) else 'Invalid'
  File "C:\Users\jholm\AppData\Local\Programs\Python\Python310\lib\enum.py", line 437, in __getattr__
    raise AttributeError(name) from None
AttributeError: is_valid

I am on Windows 11 with Vapoursynth r61 and Python 3.10.

Sometimes it may be desired to preview with ordered dithering, or even no dithering at all. An option to configure this with ease would be very convenient.

It might be nice to store the name and url of older comps in the local storage to find it back easily. You can force an update once the upload is finished, and this way users can easily find them back. Especially useful if you're unfortunate like me and the previewer often crashes directly after it's done. :(

I'd set a limit to it, though. Probably 5 comps saved by default until it starts overwriting them to avoid it from getting too busy (with a setting allowing that to be changed?)

There's an error message for the bit depth detection: QPixmap: QGuiApplication must be created before calling defaultDepth(). When the GUI instance is not ready, the function returns zero.

Gotta admit this is a weird one, because I checked the code and the primaries are indeed in the correct order in the list vspreview has.

The issue I'm seeing is that, when opening the Frame Props dialog for a script where _Primaries is set to 1, the Frame Props dialog shows "Unspecified" instead of the expected "BT.709". Matrix and Transfer properties display correctly, and all other Primaries except BT.709 also display correctly.

This is potentially related to #21, but I wasn't sure how much it overlapped so decided to create a new issue.

I think the common workflow is that most people want to have their vspreview window in the same location for each video file they're working on, rather than having it reset to the default location for each new file. Having to move the window each time is a minor annoyance rather than a significant issue, but it would be more convenient, in my opinion, to have the geometry saved globally rather than per file.

Traceback (most recent call last):
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vspreview\toolbars\misc\toolbar.py", line 183, in on_save_frame_as_clicked
    heuristics = video_heuristics(self.main.current_output.source.clip, props, string_only=True)
TypeError: video_heuristics() got an unexpected keyword argument 'string_only'

This error seems to stem from vstools.

def video_heuristics(clip: vs.VideoNode, props: vs.FrameProps | None = None, prop_in: bool = True) -> dict[str, int]:
    ...

This should probably throw a warning, but not flat-out crash vspreview.

Traceback (most recent call last):
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vspreview\toolbars\playback\toolbar.py", line 530, in on_mute_clicked
    self.setMute(not self.audio_muted)
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vspreview\toolbars\playback\toolbar.py", line 537, in setMute   
    self.play_audio()
  File "C:\Users\light\AppData\Local\Programs\Python\Python310\lib\site-packages\vspreview\toolbars\playback\toolbar.py", line 259, in play_audio
    self.current_audio_frame = self.current_audio_output.to_frame(
AttributeError: 'NoneType' object has no attribute 'to_frame'

I had a use case for this as part of a script to find the frame with the most out-of-range pixels in a video, and then display it. My hope is that it might be useful to someone else as well.

I'm not certain exactly what triggered this scenario, but the situation that occurred is that self.current_output is an attribute on the class that self is, and that attribute is set to None. hasattr returns True because there is an attribute on self called current_output, even though it is None.

TODO

Make pages for the following:

• [ ] Basic usage for beginners
• [ ] Different toolbars
• [ ] Different viewmodes

Other:

• [ ] Fix sphinx warning in action

More suggestions welcome

A neat feature may be to, when you click a button, run wwxd/scxvid on the current output node and iterate over the entire clip. Alternatively, a helper function the user can import that allows you to pass a clip and an enum determining the mode (wwxd, scxvid, both, etc. Check the old lvsfunc or vsencode code for one such example, I forgot which one has it).

Additionally, hotkeys to jump from scene to scene might be neato as well if they do not exist yet. If they do, the user can just use those binds.

This fixes the following crash scenarios:

• Hovering cursor on timeline scene notch.
• Browsing to new frames while there are listed scenes.
• Editing scene properties in the scene list dialog despite no scene selected.

It also fixes the scene label not being added for single-frame scenes. Some of these issues were caused by the PyQt6 refactor, but a couple were present beforehand.

Fixes Irrational-Encoding-Wizardry/vs-preview#62.

Crash was due to sub-layouts being included in the layout's items being iterated and sub-layouts don't contain a singular widget. Sub-layouts are now removed, cleared, and deleted. Widgets removed from the layout are deleted as before.

widget.deleteLater() will remove the parent relationship automatically so widget.setParent(None) is unnecessary.

Fixes Irrational-Encoding-Wizardry/vs-preview#63

QLayout::removeWidget: Cannot remove a null widget.
Traceback (most recent call last):
  File "vspreview/main/window.py", line 557, in switch_output
    self.switch_frame(self.current_output.last_showed_frame)
  File "vspreview/main/window.py", line 530, in switch_frame
    toolbar.on_current_frame_changed(frame)
  File "vspreview/toolbars/main/toolbar.py", line 146, in on_current_frame_changed
    self.frame_props_dialog.update_frame_props(self.main.current_output.props)
  File "vspreview/toolbars/main/dialog.py", line 117, in update_frame_props
    self.framePropsVLayout.clear()
  File "vspreview/core/abstracts.py", line 106, in clear
    widget.setParent(None)  # type: ignore
AttributeError: 'NoneType' object has no attribute 'setParent'

Hello when i tried to use it it crashes with two crashes.

CRASH: Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\vspreview\toolbars\scening\dialog.py", line 150, in on_label_changed
    index = self.tableview.selectionModel().selectedRows()[0]
IndexError: list index out of range

NEW CRASH:

Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\vspreview\main\timeline.py", line 272, in mouseMoveEvent
    QToolTip.showText(event.globalPosition(), notch.label)
TypeError: showText(QPoint, str, widget: QWidget = None, rect: QRect = {}, msecShowTime: int = -1): argument 1 has unexpected type 'QPointF' 

Per the title, I've noticed that in recent versions (using latest version from PyPi as of 12/28, about 10 minutes ago), vspreview's video output* is now automatically scaled when Windows DPI scaling is enabled, and I can't find a way to disable it (I have fiddled with the DPI option in settings, too, to no effect). This means that unless I disable DPI scaling in Windows, I can't view my filterchain without vspreview's scaling. A workaround would be greatly appreciated.

** Edit: I'm dumb, setting a custom zoom level allows bypassing this. Just assumed it'd be upscaled and then downscaled.