Fresh Windows & FontLab 7 installation, installed TypeRig via Scripts > Update/Install, restarted, and failed to run a script:

from typerig.proxy import pFont

cannot import name pFont

What am I missing?

Hello Vassil,

I don’t know where this problem exists (wheter it’s PythonQt or TypeRig or something else), but before I run TypeRig panel on macOS, my panel menus look like this:

But when I run TypeRig panel, they change to:

Is it possible that you do something in TypeRig that sets some styling of the TypeRig panel? (Which could then also influence the styling of some UI elements within FL). Because if you don’t customize anything, then it’ll be problem on some other end.

Thanks!

Vassil, please take a look at this line:

https://github.com/kateliev/TypeRig/blob/74a486c80116105116711004f64018ff6d3b3116/Lib/typerig/proxy/fl/objects/glyph.py#L171

I think it must be replaced by

self.layer(layer).mark = mark_color

to make the code work. Try to set a layer-specific flag with the method, and you will get an error. Thank you for looking into this.

For a while, I am unable to open TypeRig Panel, I get the following error:

Traceback (most recent call last):
  File "C:/Users/Adam/Documents/FontLab/FontLab 7/Scripts/TypeRig GUI/typerig-panel.py", line 24, in <module>
    import Panel 
  File "C:/Users/Adam/Documents/FontLab/FontLab 7/Scripts/TypeRig GUI\Panel\__init__.py", line 19, in <module>
    __import__(module, locals(), globals())
  File "C:/Users/Adam/Documents/FontLab/FontLab 7/Scripts/TypeRig GUI\Panel\String.py", line 38, in <module>
    from typerig import QtGui
ImportError: cannot import name QtGui

Lacking a better idea, and having noticed that a script that does work for me (Metrics) imports from typerig.gui and not typerig, I changed from typerig import QtGui to from typerig.gui import QtGui, then I got

Traceback (most recent call last):
  File "C:/Users/Adam/Documents/FontLab/FontLab 7/Scripts/TypeRig GUI/typerig-panel.py", line 24, in <module>
    import Panel 
  File "C:/Users/Adam/Documents/FontLab/FontLab 7/Scripts/TypeRig GUI\Panel\__init__.py", line 19, in <module>
    __import__(module, locals(), globals())
  File "C:/Users/Adam/Documents/FontLab/FontLab 7/Scripts/TypeRig GUI\Panel\String.py", line 40, in <module>
    from typerig.string import stringGen, stringGenPairs, strRepDict, fillerList, baseGlyphset
ImportError: No module named string

I'm on Windows btw.

Hello, there was this feature back in FL5 - copy from manual: Contour > Correct Connections to automatically fix incorrect sharp connections, that is sharp connections that can be turned into smooth connections without any change in the shape of the contour.

This is exactly what I need to do now, but I cannot find anything like that in FL7 - is there perhaps such a feature in the Typerig somewhere?

I don't wan any other Clean-up/Harmonize/Blance - just this simple task - please see attached (correct on top)

Vassil, please take a look at these lines of code that are part of the dereference() function:

https://github.com/kateliev/TypeRig/blob/85cf3dc59aa5ed7ec42cbd5501f7bbb332a68bae/Lib/typerig/proxy/fl/objects/glyph.py#L330-L335

To my understanding, dereferencing an element reference is the same as what Element > Element Reference > Unlink Reference does. If that is correct, your function does too much. It not only unlinks element references, but also removes components. Which is clear from your code:

1. You collect all element references of the specified glyph layer in a list ('only_shapes').
2. You create a clone (unlinked equivalent) of each of these references and collect these clones in a list ('clones').
3. You remove not only element references, but also components (and groups) from the glyph layer and only add the clones back in.

This way, components (and groups) are removed from the specified glyph layer. Therefore, I think you should replace

for clone in clones: wLayer.addShape(clone)

by the following:

for item in components + clones:
  wLayer.addShape(item)

This way, components are also added back in. Would that make sense?

Vassil, please take a look at the following lines:

https://github.com/kateliev/TypeRig/blob/3fbab884eb8ac28e69440dfe7249f65f543ee0bd/Lib/typerig/proxy/fl/objects/glyph.py#L266-L267

Suppose you have a glyph with layers Regular and mask.Regular having layer indices 1 and 0 respectively. Then you will see that

pGlyph().mask(layer=0)

refers to the Regular layer and not to mask.Regular. More generally, if the layer index of a mask layer is used as the value of the keyword argument layer, the function will yield the parent layer of the mask layer, not the mask layer itself. But that is probably not intended, as the description of your function says “Returns mask layer no matter the reference.”

To quickly check the behavior of the function in the described situation:

from typerig.proxy.fl.objects.glyph import *
print(pGlyph().mask(layer=0).name)

Thank you for taking a look.

I'm trying to clear anchor expressions in all masters. But pGlyph.anchors() returns flPinPoints (which I have no idea how to edit) and not flAnchors as promised.

from typerig.proxy import pFont

font = pFont()

for glyph in font.selected_pGlyphs():
  for layer in glyph.masters():
    for a in glyph.anchors(layer.name):
      print a 
      # <flPinPoint x=360 y=0 objectName='bottom' objectId=0x20623d04510>
      # ...
      # flPinPoint, not flAnchor!
      
      print a.x
      # 'flPinPoint' object has no attribute 'x'

Using FL7 7.1.4.7515. Others load fine. Error: Traceback (most recent call last): File "/Users/georgethompson/Library/Application Support/FontLab/FontLab 7/Scripts/TypeRig GUI/typerig-panel.py", line 23, in import Panel File "/Users/georgethompson/Library/Application Support/FontLab/FontLab 7/Scripts/TypeRig GUI/Panel/init.py", line 19, in import(module, locals(), globals()) File "/Users/georgethompson/Library/Application Support/FontLab/FontLab 7/Scripts/TypeRig GUI/Panel/TextBock.py", line 14, in from typerig import QtGui ImportError: cannot import name QtGui

George

Hello Vassil, how do I run a Fontlab script, in the way it modify several selected glyphs at once? So far it seems to affect just the one "current/active", lastly selected glyph only, even when multiple glyphs are selected in "Font tab" window.

Otherwise, this script was was kindly provided by you - thanks again, it has helped me a lot! :)

#FLM: Sort Contours from typerig.proxy import pFont, pGlyph sort_by_y = True # Put False here if you want them to be X sorted glyph = pGlyph() for shape in glyph.shapes(): shape.contours = sorted(shape.contours, key=lambda c:c.bounds[sort_by_y]) glyph.updateObject(glyph.fl)

Note: I'm no expert in scripting. Please help, Vit

This addresses https://github.com/kateliev/TypeRig/issues/17

The result is a very compact appearance on the Mac — but everything fits:

It’s implemented via a new typerig.QtGui module which acts as an adapter of the standard QtGui classes. Currently, it’s not very sophisticated — could be improved. But it’s better than the ugly hack with loading Fusion styling.

To do:

• use repurposed Delta Tuner version as the new Delta Panel (auto axis setup, auto layer change detection, auto glyph change);
• use entirely new GUI heavily relying on icons;
• do fixes and refactoring;

Possible .service_array bug reported by @etunni. Delta machine (delta panel) not always scaling metrics and anchors. Observed is only LSB change? To investigate further...

This code adds signals to each main menu item that prints the object name and the mouse cursor position. It shows how you can attach signals to QActions.