This PR makes discogs_client python 2 and python 3 compatible.

Notables changes include:

• switch from python-oauth2 (no py3k compatibility) to oauthlib (→ helps with #40)
• fix numerous pep8 error
• make tests deterministic

I've just added user_token "authentication".

Can't figure out how to add a test for it, but you can use this for testing:

__author__ = 'aweil'
import os
import unittest
import discogs_client

class UserTokenTest(unittest.TestCase):
    def setUp(self):
        with open(os.path.expanduser('~/.discogs_user_token'), 'rb') as f:
            self.discosgs_token = f.read().strip()

    def test_search(self):
        d = discogs_client.Client('TenukiWebApp1/0.1', user_token=self.discosgs_token)
        query_releases = d.search('Bit Shifter', type='artist')[0].releases[1].versions[0].labels[0].releases
        self.assertTrue( len(query_releases)>0)

if __name__ == '__main__':
    unittest.main()

Please let me know when/where to add documentation when available and if you want I to documentate it in the readme.

This adds richer exception information when the request token request fails. This is important because it can fail for several different reasons, including:

• bad timestamp
• bad consumer
• bad signature

This makes it at least possible to tell what's going wrong.

Before:

$ python -c "import discogs_client ; discogs_client.Client('[...]', '[...]', '[...]').get_authorize_url()"
[...]
discogs_client.exceptions.HTTPError: 401: Invalid response from request token URL.

After:

$ python -c "import discogs_client ; discogs_client.Client('[...]', '[...]', '[...]').get_authorize_url()"
[...]
discogs_client.exceptions.AuthorizationError: 401: Could not get request token. Response: 'Invalid consumer.'

This came up in https://github.com/sampsyo/beets/issues/1417.

Discogs has recently lowered their rate limit from 240 reqs/min to 60 reqs/min. This obviously means that some applications will hit the limit quite soon.

Git checkout of repository fails.... error: unable to create file discogs_client/tests/res/artists/1/releases?per_page=50&page=1.json (Invalid argument) error: unable to create file discogs_client/tests/res/artists/1/releases?per_page=50&page=2.json (Invalid argument) error: unable to create file discogs_client/tests/res/database/search?q=trash80&per_page=50&page=1.json (Invalid argument) error: unable to create file discogs_client/tests/res/masters/4242/versions?per_page=50&page=1.json (Invalid argument) error: unable to create file discogs_client/tests/res/users/example/wants?per_page=50&page=1.json (Invalid argument)

With the current git clone (but I think this was also present with the version coming from pypi) I get the following traceback:

>>> r = discogs.Release( 934425 )
>>> t = r.tracklist[9]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/discogs_client-1.1.0-py2.7.egg/discogs_client.py", line 165, in tracklist
    for track in self.data.get('tracklist', []):
  File "/usr/local/lib/python2.7/dist-packages/discogs_client-1.1.0-py2.7.egg/discogs_client.py", line 52, in data
    if self._response.content and self._response.status_code == 200:
  File "/usr/local/lib/python2.7/dist-packages/discogs_client-1.1.0-py2.7.egg/discogs_client.py", line 38, in _response
    self._cached_response = requests.get(self._uri, self._params, self._headers)
TypeError: get() takes exactly 1 argument (3 given)

during the install (python setup.py install) it installed version 0.6.1 of the python-requests library.

I was doing a fork but right now git push doesn't seem to be working, so here is just the trivial patch as plain text:

diff --git a/discogs_client.py b/discogs_client.py
index f52d769..ee2e48d 100644
--- a/discogs_client.py
+++ b/discogs_client.py
@@ -35,7 +35,7 @@ class APIBase(object):
         if not self._cached_response:
             if not self._check_user_agent():
                 raise DiscogsAPIError, 'Invalid or no User-Agent set'
-            self._cached_response = requests.get(self._uri, self._params, self._headers)
+            self._cached_response = requests.get(self._uri, params=self._params, headers=self._headers)
 
         return self._cached_response

Here is a minimal example of my attempts to interact with the Discogs API:

from SensitiveInformation.discogs_application_info import provide_discogs_auth, provide_verifier
import discogs_client

discogs_consumer_key, discogs_consumer_secret = provide_discogs_auth()
discogs = discogs_client.Client(user_agent="ThoughfulMachineLearning",
                                consumer_key=discogs_consumer_key,
                          consumer_secret=discogs_consumer_secret)
discogs_auth_url = discogs.get_authorize_url()
discogs.get_access_token(verifier=provide_verifier())
discogs.identity()

The functions provide_discogs_auth and provide_verifier simply return the consumer key & secret and the verifier from user authorization. get_access_token returns the access key and secret as expected.

However, on the last line, when I make an API call, I get:

Out[38]: In[39]: discogs.identity()
Traceback (most recent call last):
Out[39]:   File "/usr/local/lib/python3.4/dist-packages/IPython/core/formatters.py", line 219, in catch_format_error
    r = method(self, *args, **kwargs)
  File "/usr/local/lib/python3.4/dist-packages/IPython/core/formatters.py", line 690, in __call__
    printer.pretty(obj)
  File "/usr/local/lib/python3.4/dist-packages/IPython/lib/pretty.py", line 407, in pretty
    return _default_pprint(obj, self, cycle)
  File "/usr/local/lib/python3.4/dist-packages/IPython/lib/pretty.py", line 527, in _default_pprint
    _repr_pprint(obj, p, cycle)
  File "/usr/local/lib/python3.4/dist-packages/IPython/lib/pretty.py", line 709, in _repr_pprint
    output = repr(obj)
TypeError: __repr__ returned non-string (type bytes)

Not sure if this is related to IPython or the client library, but would appreciate help either way. Thanks.

Fix Issue #37 -- allow to clone properly on Windows.

• Renamed all test files to replace '?' with '_'
• Changed FileSystemFetcher to likewise replace '?' with '_' when loading a test file
• Added logic to FileSystemFetcher to check for all permutations of parameters contained in a test file's name.
• Removed symlinks from repo.
• The repo now clones cleanly on Windows.
• Unit tests passed.

Searching for a non-ASCII term causes this error:

>>> import discogs_client
>>> c = discogs_client.Client('user_agent', 'bogus_key', 'bogus_secret')
>>> c.search(u'caf\xe9'.encode('utf8')).page(1)
Traceback (most recent call last):
[ ... snip ... ]
  File "/usr/local/lib/python2.7/site-packages/oauth2/__init__.py", line 442, in to_url
    urllib.urlencode(query, True), fragment)
  File "/usr/local/Cellar/python/2.7.8_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib.py", line 1357, in urlencode
    l.append(k + '=' + quote_plus(str(elt)))
UnicodeEncodeError: 'ascii' codec can't encode characters in position 3-4: ordinal not in range(128)

This is due to a known bug in python-oauth2: https://github.com/simplegeo/python-oauth2/issues/154. That library, unfortunately, appears to be abandoned: the last commit was in 2011 (c.f. this lament over the sorry state of Python OAuth libraries).

It's worth noting that this was not an issue when sending non-ASCII requests without OAuth authentication because they don't go through the broken library. This has only come up recently because the search API now requires authentication, so we're now these previously-working requests are now hitting this bug.

As unattractive as it seems, I think the only solution may be to move to a more modern OAuth library. Personally, I've had success with rauth.

from discogs_client import Client, Release


client = Client('python')
releases = [i for i in client.search('Flying Horseman') if isinstance(i, Release)]

r = releases[3]
print r.title           # Flying Horseman - City Same City
print r.data['title']   # Flying Horseman - City Same City
print r.master.title    # City Same City
print r.title           # City Same City

This behavior is really strange: Accessing Release.master.title also changes Release.title. I can't find a way to get just album name without artist, it works only if I access master first.

let us say i want to get a tracklist of this version of a release - https://www.discogs.com/Edward-Ka-Spel-Dream-Logik-Part-Two/master/277838 - works fine because it has only one side

but

let us say i want to get a tracklist of this version of a release which is double side LTD - https://www.discogs.com/Edward-Ka-Spel-Dream-Logik-Part-Two/release/1425757

it returns a buggy list with two more strings which ARE NOT TRACKS but names of each side.