@anemitz & @thomasst do you guys have any plans for the next milestone / release of flask-mongoengine?

Unfortunately, I dont have the time available at the minute to fix the issues and push a release. If you are in the same boat, I'm happy to try and draft in more maintainers!

Any potential maintainers - please post here if you want to help further flask-mongoengine - I'm happy to mentor as well!

pip install flask-mongoengine Collecting flask-mongoengine Using cached flask-mongoengine-0.9.5.tar.gz (111 kB) ERROR: Command errored out with exit status 1: command: 'c:\users\keerthivasan\desktop\pybox\venv\scripts\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\Users\keerthivasan\AppData\Local

\Temp\pip-install-su4c26f2\flask-mongoengine\setup.py'"'"'; file='"'"'C:\User s\keerthivasan\AppData\Local\Temp\pip-install-su4c26f2\flask-mongoengine\setup. py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'" '\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg _info --egg-base 'C:\Users\keerthivasan\AppData\Local\Temp\pip-pip-egg-info-xw613uem' cwd: C:\Users\keerthivasan\AppData\Local\Temp\pip-install-su4c26f2\flask-mong oengine\

im trying to install flask-mongoengine but can't for some reasons. Help me out

i would love to be able to have a mongomock connection if app.config['TESTING'] is true this would allow easier testing of the flask application (otherwise an in-memory mongo like the one implemented in ming would be great)

This line is the culprit. Was noticed before the release of 0.8 :(

I get a failure: pymongo.errors.ServerSelectionTimeoutError: r2d2_local:27017: [Errno -2] Name or service not known

r2d2_local is the name of my database, not my host.

Reverting/ fixing changes from https://github.com/MongoEngine/flask-mongoengine/pull/231. Relevant criticism: https://github.com/MongoEngine/flask-mongoengine/pull/231#issuecomment-255568259.

The main goal of this PR is to fix a buggy connection code introduced in v0.8. It also makes the code cleaner and easier to understand through a better separation of responsibilities and a better documentation.

This is unfortunately dropping support for mongomock, but many things were broken about it to begin with. We should revisit adding it in the future, though personally I don't see a point for it... In the age of Travis/CircleCI/etc., it's so easy to run a real MongoDB in your tests.

Things to test manually:

• [x] Connecting to multiple mongos in a sharded cluster
• [x] Connecting to a replica set
• [x] Connecting to a server that requires authentication
• [x] All of the above via a MongoDB URI

Fixes #266 #283 #282 #259 #258 #254 #250 #247 #267

The email field validates '' differently than None. '' is an invalid email, None is a valid input. model_form based Forms return the wrong data.

from flask import Flask
from flask.ext.mongoengine import MongoEngine
import unittest
from flask.ext.mongoengine.wtf import model_form
from werkzeug.datastructures import MultiDict

app = Flask(__name__)

app.config.update(
    DEBUG = True,
    TESTING = True,
    MONGODB_HOST = 'localhost',
    MONGODB_PORT = '27017',
    MONGODB_DB = 'mongorest_example_app',
)

db = MongoEngine(app)

class User(db.Document):
    email = db.EmailField(required=False)
    name = db.StringField()

class FieldTestCase(unittest.TestCase):
    def setUp(self):
        self.app = app.test_client()

    def test_emptyemail(self):
        with app.test_request_context('/?name=Peter'):
            TestForm = model_form(User)
            data = MultiDict({'name':'John Doe'})
            form = TestForm(data,csrf_enabled=False)
            assert form.validate()
            assert form.data['email'] == None
# form.data['email'] is '' instaed of None

In master branch, flask_mongoengine/connection.py, line 265:

if conn_setting.pop('replicaset', None):
    resolved['replicaSet'] = conn_setting.pop('replicaset', None)

what is f***ing going on lol

Because dict.pop() will return and also remove specific key value pair from dict, so we cannot do dict.pop() twice. Actually this code should be:

replica_set = conn_setting.pop('replicaset', None)
if replica_set:
    resolved['replicaSet'] = replica_set

Added a wrapper sub-class WtfBaseField to allow additional WTForm field parameters and settings needed by flask-mongoengine, without necessarily going through to the core mongoengine BaseField.

• flask_mongoengine/__init__.py has patching to redirect wtf mongoengine Fields of base BaseField to use WtfBaseField
• wtf/orm.py now has 'validators' and 'filters' allowed on behalf wtf model field generator.

Example:

 class Contact(db.Document)
    telephone = db.StringField(
        required=True,
        validators=[
          validators.InputRequired(message=u'Missing telephone.'),
        ],
        max_length=50
    )

This PR allows to use MONGODB_CONNECT parameter and document both the existing MONGO_SETTINGS['connect'] and the new MONGODB_CONNECT parameters.

I had to read #255 to discover this possibility which isn't documented and this solve a common issue.

Context: this feature seems to appear in #280 but there was issues and PRs before. ex: #255, #266, #126

This is a follow-up after #270. I tightened flake8's code checking, added flake8-import-order and fixed existing imports (see https://www.python.org/dev/peps/pep-0008/#imports for details), and added some minor style tweaks.

@lafrech let me know what you think :)

Hi! I would like to use a StringField with choices as, instead of a SelectField or MultiSelectField, RadioField For that I modify the orm.py adding 2 lines of code Instead of:

if field.choices:
            kwargs['choices'] = field.choices

            if ftype in self.converters:
                kwargs["coerce"] = self.coerce(ftype)
            if kwargs.pop('multiple', False):
                return f.SelectMultipleField(**kwargs)
            return f.SelectField(**kwargs)

I have

if field.choices:
            kwargs['choices'] = field.choices

            if ftype in self.converters:
                kwargs["coerce"] = self.coerce(ftype)
            if kwargs.pop('multiple', False):
                return f.SelectMultipleField(**kwargs)
            if kwargs.pop('radio', False):
                return f.RadioField(**kwargs)
            return f.SelectField(**kwargs)

Notice this 2 new lines:

            if kwargs.pop('radio', False):
                return f.RadioField(**kwargs)

I would prefer to make a pull request but I wasn't able to run the test (if you could point me to the test help I would apreciate it)

In the other hand, I would prefer that choices will be treated in the converter to allow subclassing better but this change will be ok for me

What do you think?

Thanks!

Is new release planned any time soon? I can see that release tag for 1.0.0 was 2020.

I can see that quite a lot of work is merged into master, but would avoid using it for production since it might not be stable enough.

There are small typos in:

• CONTRIBUTING.md
• docs/forms.md

Fixes:

• Should read significant rather than signigicant.
• Should read responsibility rather than responsobility.
• Should read hardcoded rather than hardcodded.
• Should read extract rather than exctract.

Semi-automated pull request generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

I am implementing similar logic in Flask-Security - so stole some code :-)

The code:

class MongoEngineJSONProvider(superclass):
        """A JSON Provider update for Flask 2.2.0+"""

        @staticmethod
        def default(obj):
            """Extend JSONProvider default static method, with Mongo objects."""
            if isinstance(
                obj,
                (BaseDocument, QuerySet, CommandCursor, DBRef, ObjectId),
            ):
                return _convert_mongo_objects(obj)
            return super().default(obj)

I don't think is quite right - using super() for static methods doesn't work - you need to do something like: return super(MongoEngineJSONProvider, MongoEngineJSONProvider).default(obj)

Explain:

• [ ] New installation behavior
• [ ] Recommended approach to config configuration
• [ ] New restriction to passing arguments on model field definition
• [ ] ORM module deprecation